[MCP SDK] Example update to use proper logging #331
Conversation
ineersa
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Bug
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MCP SDK example to use proper Monolog logging instead of Symfony's ConsoleLogger. The change addresses issue #306 by implementing structured JSON logging to STDERR as required by the MCP protocol.
Key changes:
- Replace Symfony ConsoleLogger with Monolog logger configured for JSON output to STDERR
- Add Monolog as a development dependency
- Include detailed comments explaining the logging requirements and limitations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/mcp-sdk/examples/cli/index.php | Replace ConsoleLogger with Monolog using StreamHandler and JsonFormatter for STDERR output |
| src/mcp-sdk/composer.json | Add monolog/monolog as development dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| $logger = new SymfonyConsole\Logger\ConsoleLogger($output); | ||
|
|
||
| // Setup *Monolog* logger, logger must output JSON to stream to STDERR | ||
| // **WARNING** this will work only on the development stage with @modelcontextprotocol/inspector, but not in a real client |
There was a problem hiding this comment.
[nitpick] The comment uses Markdown formatting (Monolog and WARNING) which is not appropriate for PHP code comments. Consider using plain text formatting for better readability in the source code.
| // **WARNING** this will work only on the development stage with @modelcontextprotocol/inspector, but not in a real client | |
| // Setup Monolog logger, logger must output JSON to stream to STDERR | |
| // WARNING: this will work only on the development stage with @modelcontextprotocol/inspector, but not in a real client |
Copilot uses AI. Check for mistakes.
Added
monologasdevdependency.Swapped
ConsoleLoggerto Monolog -> STDERR with JsonFormatter.Added commentary with explanation